MAYA-111084 - LE save icon missing when scaling is 125% #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We don't provide icons at 125% so make sure to account for that.
seando-adsk
commented
May 11, 2021
Comment on lines
+57
to
+66
| #ifdef Q_OS_DARWIN | ||
| return baseName + "_100.png"; | ||
| #else | ||
| const auto scale = utils->dpiScale(); | ||
| if (scale >= 2.0) | ||
| return baseName + "_200.png"; | ||
| else if (scale >= 1.5) | ||
| return baseName + "_150.png"; | ||
| return baseName + "_100.png"; | ||
| #endif |
There was a problem hiding this comment.
When running at custom scaling 125%, the base name would become "_125.png" - but we do not provide at 125% icon file. So reworked the code to make sure we always return either _100/_150/_100 - which are the three sizes we support.
seando-adsk
commented
May 11, 2021
Comment on lines
+82
to
+83
| background-position: center center; | ||
| background-repeat: no-repeat; |
There was a problem hiding this comment.
At 125 the icon used is _100 so there was extra space and the icon was centered and actually repeated. So this centers it (vert/horz) and turns off repeat. I checked all supported scaling factors (100/125/150/200).
seando-adsk
added
the
ready-for-merge
kxl-adsk
deleted the
donnels/MAYA-111084/layer_editor_icon_missing_at_scaling_125
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-111084 - LE save icon missing when scaling is 125%