Fixed bug with visibility determination #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ermining visiblity
HamedSabri-adsk
approved these changes
Jun 11, 2021
| const MDAGDrawOverrideInfo drawOverrideInfo = dagPath.getDrawOverrideInfo(); | ||
| if (drawOverrideInfo.fOverrideEnabled && drawOverrideInfo.fDisplayType == MDAGDrawOverrideInfo::kDisplayTypeTemplate) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Lgtm! So to be clear, previously this function didn't return the state correctly when the draw override's display type was set to "Template".
|
@ysiewappl Please fix clang-format so we can start PF for this change. |
kxl-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all:
This small PR fixes an issue where if you have the Draw Overrides option enabled on a DAG node set to template instead of using the one in the Display rollout, the utility function in Maya-USD would report it to be renderable instead of not. This was causing issues for us internally in our own internal chaser plugins when determining visibility state.
Please review and raise any concerns.