MAYA-111898 - MaterialX UV0 defaultgeomprop to st primvar #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaterialX has a lot of node definitions that use a UV0 defaultgeomprop to automatically connect to UV stream at index zero. Since USD is name based, and we specified a canonical naming scheme for UV sets in PR #1528, we can insert a geompropvalue primvar reader that will allow that shader to work. MaterialX can also specify a UV stream by index using a "texcoord" geometry node. For these, we substitute a geompropvalue primvar reader that refers to the primvar name we assigned for that index: UV2 -> st2
| (ND_texcoord_vector3) | ||
| // Color at vertices also affect topo, but we have not locked a naming scheme to go from index | ||
| // based to name based as we did for UV sets. We will mark them as topo-affecting, but there is | ||
| // nothing we can do to link them correctly to a primvar without specifying a naming scheme. |
There was a problem hiding this comment.
Should we also specify a primvar naming scheme for these as well?
There was a problem hiding this comment.
Is there any scheme existing out there already?
| { | ||
| uniform token info:id = "ND_noise2d_float" | ||
| float inputs:amplitude = 0.5 | ||
| float2 inputs:texcoord.connect = </pCube1/Looks/standardSurface2SG/MayaNG_standardSurface2SG/UV1.outputs:out> |
There was a problem hiding this comment.
Explicitly connected to a texcoord reader for UV at index 1.
| def Shader "UV1" | ||
| { | ||
| uniform token info:id = "ND_texcoord_vector2" | ||
| int inputs:index = 1 |
There was a problem hiding this comment.
Will be replaced with geompropvalue for "st1".
| uniform token info:id = "ND_ramptb_color3" | ||
| color3f inputs:valuet = (0.0, 1.0, 0.5) | ||
| color3f inputs:valueb = (1.0, 0.5, 0.0) | ||
| color3f outputs:out |
There was a problem hiding this comment.
Unconnected texcoord input. Will be auto-connected to an auto-added ST_reader node that reads primvar "st".
| asset inputs:file = @grid.png@ | ||
| string inputs:uaddressmode = "periodic" | ||
| string inputs:vaddressmode = "periodic" | ||
| color4f outputs:out |
There was a problem hiding this comment.
Also has an unconnected texcoord reader that will auto-connect to the same ST_reader as the ramp1 node.
| @@ -0,0 +1,107 @@ | |||
| #usda 1.0 | |||
| ( | |||
There was a problem hiding this comment.
If the "HDVP2_DEBUG_MATERIAL" TF_DEBUG flag is set, you will see the corrected MaterialX document printed in the output:
<?xml version="1.0"?>
<materialx version="1.38" xmlns:xi="http://www.w3.org/2001/XInclude">
<standard_surface name="SR_USD_Mtlx_VP2_Material" type="surfaceshader">
<input name="base_color" type="color3" output="base_color_out" nodegraph="NG_Maya" />
</standard_surface>
<surfacematerial name="USD_Mtlx_VP2_Material" type="material">
<input name="surfaceshader" type="surfaceshader" nodename="SR_USD_Mtlx_VP2_Material" />
</surfacematerial>
<nodegraph name="NG_Maya">
<mix name="N1" type="color3">
<input name="bg" type="color3" nodename="N6" />
<input name="fg" type="color3" nodename="N5" />
<input name="mix" type="float" nodename="N2" />
</mix>
<swizzle name="N6" type="color3">
<input name="channels" type="string" value="rgb" />
<input name="in" type="color4" nodename="N7" />
</swizzle>
<image name="N7" type="color4">
<input name="texcoord" type="vector2" defaultgeomprop="UV0" uiname="Texture Coordinates" nodename="ST_reader" />
</image>
<ramptb name="N5" type="color3">
<input name="texcoord" type="vector2" defaultgeomprop="UV0" nodename="ST_reader" />
</ramptb>
<add name="N2" type="float">
<input name="in1" type="float" nodename="N3" />
</add>
<noise2d name="N3" type="float">
<input name="texcoord" type="vector2" nodename="N4" />
</noise2d>
<output name="base_color_out" type="color3" nodename="N1" />
<geompropvalue name="ST_reader" type="vector2">
<input name="geomprop" type="string" value="st" uniform="true" />
</geompropvalue>
<geompropvalue name="N4" type="vector2">
<input name="geomprop" type="string" value="st1" uniform="true" />
</geompropvalue>
</nodegraph>
</materialx>
| // Points and normals always are at the beginning of vertex requirements: | ||
| addPrimvar(HdTokens->points); | ||
| addPrimvar(HdTokens->normals); | ||
| // Then add required primvars *in order*: |
There was a problem hiding this comment.
The MaterialX unit test had st and st1 swapped 50% of the time. This makes sure the order stays correct.
williamkrick
approved these changes
Jul 5, 2021
JGamache-autodesk
added
the
ready-for-merge
kxl-adsk
approved these changes
Jul 5, 2021
| (ND_texcoord_vector3) | ||
| // Color at vertices also affect topo, but we have not locked a naming scheme to go from index | ||
| // based to name based as we did for UV sets. We will mark them as topo-affecting, but there is | ||
| // nothing we can do to link them correctly to a primvar without specifying a naming scheme. |
There was a problem hiding this comment.
Is there any scheme existing out there already?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaterialX has a lot of node definitions that use a UV0 defaultgeomprop to automatically connect to UV stream at index zero. Since USD is name based, and we specified a canonical naming scheme for UV sets in PR #1528, we can insert a geompropvalue primvar reader that will allow that shader to work.
MaterialX can also specify a UV stream by index using a "texcoord" geometry node. For these, we substitute a geompropvalue primvar reader that refers to the primvar name we assigned for that index: UV2 -> st2