Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAYA-111902 Review all standard surface default values #1560

Merged
merged 2 commits into from
Jul 8, 2021
Merged

MAYA-111902 Review all standard surface default values #1560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eda376
MAYA-111902 Review all standard surface default values
JGamache-autodesk Jul 7, 2021
a9c56af
Fix builds.
JGamache-autodesk Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/usd/translators/shading/mtlxStandardSurfaceWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,11 @@ MaterialXTranslators_StandardSurfaceWriter::MaterialXTranslators_StandardSurface

const TfToken usdAttrName = renaming->second;

// Keep our authoring sparse by ignoring attributes with no values set
// and no connections. We know that the default value of base and base
// color diverged between Maya and MaterialX in version 1.38.
// Keep our authoring sparse by ignoring attributes with no values set and no connections.
// Some attributes with an history of default value updates will be written always.
if (!(UsdMayaUtil::IsAuthored(attrPlug) || usdAttrName == TrMtlxTokens->base
|| usdAttrName == TrMtlxTokens->base_color)
|| usdAttrName == TrMtlxTokens->base_color || usdAttrName == TrMtlxTokens->specular
|| usdAttrName == TrMtlxTokens->specular_roughness)
&& !attrPlug.isConnected()) {
continue;
}
Expand Down