MAYA-112854 - Fix warnings from USDZ texture import #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not check folders if not importing USDZ textures - Create sourceImages if no path was given, and there is an active project, and the sourceImage folder is not yet created in that project.
kxl-adsk
reviewed
Jul 21, 2021
| @@ -65,6 +66,10 @@ def __testUsdPreviewSurfaceRoundtrip(self, | |||
| """ | |||
| Tests that a usdPreviewSurface exports and imports correctly. | |||
| """ | |||
| mark = Tf.Error.Mark() | |||
| mark.SetMark() | |||
| self.assertTrue(mark.IsClean()) | |||
There was a problem hiding this comment.
This unit test used to report the "sourceImage" error 10 times. Adding TfMarks makes sure the unit test runs clean and proves the issue is fixed.
There was a problem hiding this comment.
(would be a good idea to generalize the use of these marks to make sure we never ignore a USD error)
| image_path = os.path.join(project_path, cmds.workspace(fre="sourceImages")) | ||
| # Purposefully erase the sourceimage directory: | ||
| if os.path.isdir(image_path): | ||
| shutil.rmtree(image_path) |
There was a problem hiding this comment.
Specifically testing import into a missing sourceImages folder:
kxl-adsk
approved these changes
Jul 21, 2021
JGamache-autodesk
added
the
ready-for-merge
|
Got the expected license failure on OS/X. So ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1588