Improperly created scene item must not crash move tool. #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Aug 18, 2021
| @@ -394,5 +394,37 @@ def createCommonAPI(testCase, sphereXformable): | |||
|
|
|||
| self.runTestOpUndo(createCommonAPI, 'xformOp:translate') | |||
|
|
|||
| def testBadSceneItem(self): | |||
There was a problem hiding this comment.
Test Driven Development: wrote the test first, it crashed and failed, wrote the fix, test passes.
seando-adsk
added
ready-for-merge
seando-adsk
deleted the
tremblp/MAYA-112601/fix_ufe_v2_transform3d_creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1596
fixed crashing on improperly created scene items for UFE v1. This pull request does more of the same, for UFE v2 this time.