Boudrey/maya 114428/mayapy #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to be able to debug unit tests on Linux and OSX directly. OSX debugging support
This reverts commit a3f7800.
boudrey
commented
Oct 28, 2021
| @@ -61,7 +61,7 @@ set(CMAKE_MODULE_PATH | |||
| ) | |||
|
|
|||
| # Use RUNPATH instead of RPATH for all shared libs, executables and modules on Linux | |||
| if(IS_LINUX) | |||
There was a problem hiding this comment.
Not sure it ever worked, but it was a good intention and didn't seems to affect the build.
There was a problem hiding this comment.
It probably didn't. The var "IS_LINUX" is set from utils.cmake which isn't included until line 99 below.
boudrey
commented
Oct 28, 2021
boudrey
commented
Oct 28, 2021
I guess that many previous hacks could be removed now.
seando-adsk
approved these changes
Oct 28, 2021
| @@ -61,7 +61,7 @@ set(CMAKE_MODULE_PATH | |||
| ) | |||
|
|
|||
| # Use RUNPATH instead of RPATH for all shared libs, executables and modules on Linux | |||
| if(IS_LINUX) | |||
There was a problem hiding this comment.
It probably didn't. The var "IS_LINUX" is set from utils.cmake which isn't included until line 99 below.
boudrey
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.