Fix support for normal map channel connections #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGamache-autodesk
previously approved these changes
Nov 12, 2021
test/lib/usd/translators/UsdExportUsdPreviewSurfaceTest/UsdExportUsdPreviewSurfaceTest.ma
Outdated
Show resolved
Hide resolved
|
Also I see a build failure for Windows 2022, but I don't see anything in the logs saying what is failing. Any ideas? EDIT: Actually I see that it's failing on the same error in the other PR I have up right now. So I'm assuming it's something broken on the CI setup? But if not, please let me know. |
|
@dgovil I don't expect it to be related to this PR either, please ignore. |
JGamache-autodesk
approved these changes
Nov 15, 2021
JGamache-autodesk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression our TD (Stella) had noticed from 73fe1f8 that caused our normal map connections to not export properly.
This patch resolves the issues for us by allowing normal maps to be connected as before, and includes tests to verify it.