MAYA-110276 - USD: curves drawing color is the exact same as the maya viewport Gray background #1998
Conversation
| if (colorArray.empty()) { | ||
| colorArray.push_back(GfVec3f(0.18f, 0.18f, 0.18f)); | ||
| MDoubleArray curveColorResult; | ||
| MGlobal::executeCommand( |
There was a problem hiding this comment.
I think that this is not safe to call here. MGlobal::executeCommand calls into Maya's command engine which is not threadsafe. This code can be executed in parallel during the USD sync, so if multiple threads got in here together it could crash.
I think the approach should be to move the code that queries the colors over to ProxyRenderDelegate::update(). There we know Maya is executing serially so we should be able to safely call the command engine, save the values and then reference them here.
There was a problem hiding this comment.
Right. This may be unsafe. I will make sure to address that.
…nd Engine from USD Sync methods. Use the mutex for getting the curves' default color.
|
@williamkrick There is a call to MGlobal::executeCommandStringResult inside HdVP2Material::Sync that we should probably also fix in the same way that this one. |
|
@vlasovi You are right I think we should handle that MGlobal call in a similar way, it is nice to encapsulate that kind of thing. In the HdVP2Material case we won't have a race. The material is an sprim and sprims get their sync calls serially. basisCurve's are rprims and get the parallel sync. You can see the code responsible for that in I still prefer to encapsulate that global access. |
kxl-adsk
added
the
ready-for-merge
USD curves default color now matches Maya curves default color