Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-113541 Allow updating registered Python class #2044

Merged
merged 3 commits into from
Jan 31, 2022

Conversation

JGamache-autodesk
Copy link
Collaborator

Allow updating class registrations while actively implementing prim reader/writer/updaters and all other
class-based MayaUSD Python workflows.

Allow updating class registrations while actively implementing prim reader/writer/updaters and all other
class-based MayaUSD Python workflows.
}

// Create a new wrapper for a Python class that is seen for the first time for a given
// purpose. It we already have a registration for this purpose: update the class to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo It -> If


// Generates a unique key based on the name of the class, along with the class
// purpose:
static std::string GetKey(boost::python::object cl, const std::string& mayaTypeName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the GetKey functions are mostly doing the same thing. The common part could be in a function in UsdMayaPythonObjectRegistry.

Copy link
Contributor

@boudrey boudrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Jan 31, 2022
@kxl-adsk kxl-adsk merged commit 6fd7cb9 into dev Jan 31, 2022
@kxl-adsk kxl-adsk deleted the t_gamaj/MAYA-113541/allow_registration_updates branch January 31, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export materials ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants