-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-113541 Allow updating registered Python class #2044
Conversation
Allow updating class registrations while actively implementing prim reader/writer/updaters and all other class-based MayaUSD Python workflows.
} | ||
|
||
// Create a new wrapper for a Python class that is seen for the first time for a given | ||
// purpose. It we already have a registration for this purpose: update the class to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo It -> If
|
||
// Generates a unique key based on the name of the class, along with the class | ||
// purpose: | ||
static std::string GetKey(boost::python::object cl, const std::string& mayaTypeName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the GetKey functions are mostly doing the same thing. The common part could be in a function in UsdMayaPythonObjectRegistry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring!
Allow updating class registrations while actively implementing prim reader/writer/updaters and all other
class-based MayaUSD Python workflows.