Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ufe bbox support dev #210

Merged
merged 7 commits into from
Jan 31, 2020
Merged

Ufe bbox support dev #210

merged 7 commits into from
Jan 31, 2020

Conversation

ppt-adsk
Copy link
Collaborator

No description provided.

ppt-adsk
ppt-adsk commented Jan 21, 2020
View reviewed changes
lib/ufe/Global.cpp Show resolved Hide resolved
lib/ufe/UsdObject3d.cpp Show resolved Hide resolved
lib/ufe/UsdObject3d.h Show resolved Hide resolved
lib/ufe/UsdObject3dHandler.cpp Show resolved Hide resolved
lib/ufe/Utils.cpp Show resolved Hide resolved
test/lib/ufe/testAttribute.py Outdated Show resolved Hide resolved
@kxl-adsk
Copy link

@pilarmolinalopez can you help review this change?

pilarmolinalopez
pilarmolinalopez approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@pilarmolinalopez pilarmolinalopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ppt-adsk
Copy link
Collaborator Author

Thanks Pilar for the code review, very appreciated.

kxl-adsk
kxl-adsk suggested changes Jan 24, 2020
View reviewed changes
Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to fix missing define on previous releases of Maya:

        UFE_V2(auto usdAttributesHandler = UsdAttributesHandler::create();)

kxl-adsk
kxl-adsk suggested changes Jan 28, 2020
View reviewed changes
Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following tests are failing on Windows:
7: ======================================================================
7: ERROR: testAttributeDouble3 (testAttribute.AttributeTestCase)
7: Test the Double3 attribute type.
7: ----------------------------------------------------------------------
7: Traceback (most recent call last):
7: File "testAttribute.py", line 334, in testAttributeDouble3
7: assertVectorAlmostEqual(self, ufeAttr.get(), usdAttr.Get())
7: File "ufeTestUtils\testUtils.py", line 22, in assertVectorAlmostEqual
7: for va, vb in zip(a, b):
7: TypeError: zip argument #1 must support iteration
7:
7: ======================================================================
7: ERROR: testAttributeFloat3 (testAttribute.AttributeTestCase)
7: Test the Float3 attribute type.
7: ----------------------------------------------------------------------
7: Traceback (most recent call last):
7: File "testAttribute.py", line 310, in testAttributeFloat3
7: assertVectorAlmostEqual(self, ufeAttr.get(), usdAttr.Get())
7: File "ufeTestUtils\testUtils.py", line 22, in assertVectorAlmostEqual
7: for va, vb in zip(a, b):
7: TypeError: zip argument #1 must support iteration
7:
7: ----------------------------------------------------------------------
7: Ran 10 tests in 1.022s
7:
7: FAILED (errors=2)
1/2 Test #7: testAttribute ....................***Failed 6.34 sec

kxl-adsk
kxl-adsk approved these changes Jan 31, 2020
View reviewed changes
Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kxl-adsk kxl-adsk merged commit 5cd2826 into dev Jan 31, 2020
@kxl-adsk kxl-adsk deleted the ufe_bbox_support_dev branch January 31, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pilarmolinalopez pilarmolinalopez pilarmolinalopez approved these changes

@seando-adsk seando-adsk seando-adsk approved these changes

@kxl-adsk kxl-adsk kxl-adsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppt-adsk @kxl-adsk @pilarmolinalopez @seando-adsk