MAYA-114593 preserve load state of prims #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code to preserve the loaded or unloaded state of a prim when grouped, reparented or renamed. Note that we don't remove the old rules when duplicating since the source prim still exists. - Refactor the existing load-state preservation code in reusable functions. - Use them in the duplicate, rename, and reparenting commands.
ppt-adsk
previously approved these changes
Feb 24, 2022
lib/mayaUsd/utils/loadRules.cpp
Outdated
|
|
||
| // Retrieve the effective rule for the source path. | ||
| // | ||
| // The reason we retrieve the effetive rule is that even |
There was a problem hiding this comment.
"effetive" --> "effective".
lib/mayaUsd/utils/loadRules.cpp
Outdated
| // | ||
| // Note: the UsdStageLoadRules has a Minimize function that simplifies | ||
| // rules, but we don't want to change rules the user might have set. | ||
| // The user may expect those rules to exists for some future purpose |
There was a problem hiding this comment.
"to exists" --> "to exist".
ppt-adsk
approved these changes
Feb 24, 2022
|
Only the known flaky test TestALUSDMayaPython_LayerManager failed in the interactive linux instance. |
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to preserve the loaded or unloaded state of a prim when grouped, reparented or renamed. Note that we don't remove the old rules when duplicating since the source prim still exists.