MAYA-107839 [GitHub 800] USD: exporting the attached maya file using … #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…USD takes extremely long I was able to cut in half the time to export going from about 10 min. to 5 min with an improved algorithm for shapes below dagpath. The next bottleneck is here with 87% of the time spent: https://github.com/Autodesk/maya-usd/blob/dev/lib/usd/translators/nurbsCurveWriter.cpp#L61
boudrey
commented
Mar 4, 2022
| @@ -120,9 +120,21 @@ bool UsdMayaWriteJobContext::IsMergedTransform(const MDagPath& path) const | |||
|
|
|||
| // Any transform with multiple (non-intermediate) shapes below is | |||
| // non-mergeable. | |||
| unsigned int numberOfShapesDirectlyBelow = 0u; | |||
| path.numberOfShapesDirectlyBelow(numberOfShapesDirectlyBelow); | |||
There was a problem hiding this comment.
I translated the code of numberOfShapesDirectlyBelow in OpenMaya code and stop if there is more than one shape instead of going through all the shapes to count them since it is not necessary saving 1/2 of the export time,
There was a problem hiding this comment.
Thanks Yves. Can you add in a comment saying that you expanded out the implementation of MDagPath::numberOfShapesDirectlyBelow() to cut down the time by half. Otherwise, someone will come in and replace your code with numberOfShapesDirectlyBelow().
ppt-adsk
approved these changes
Mar 7, 2022
boudrey
added
the
ready-for-merge
boudrey
removed
the
ready-for-merge
boudrey
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…USD takes extremely long
I was able to cut in half the time to export going from about 10 min. to 5 min with an improved algorithm for shapes below dagpath.
The next bottleneck is here with 87% of the time spent: https://github.com/Autodesk/maya-usd/blob/dev/lib/usd/translators/nurbsCurveWriter.cpp#L61