MAYA-122134 bad variant cache with empty pref #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix that caching to USD fails when the Maya prefs are reset. Also add word-wrap to the descriptions UI.
seando-adsk
requested changes
Mar 18, 2022
| @@ -116,7 +116,7 @@ proc fileOptionsTabPage(string $tabLayout) | |||
| setParent $topForm; | |||
| frameLayout -label `getMayaUsdLibString("kMayaRefDescription")`; | |||
| columnLayout -adjustableColumn true; | |||
| text -align "left" -label `getMayaUsdLibString("kMayaRefAddToUSDDescription")`; | |||
| text -align "left" -wordWrap 1 -label `getMayaUsdLibString("kMayaRefAddToUSDDescription")`; | |||
There was a problem hiding this comment.
Doesn't wordWrap flag take a boolean? Using a 1 makes it seems like its some kind of word wrap value choice.
There was a problem hiding this comment.
I thought MEL did not have a boolean type as I've seen int, 0 and 1 used in most places. It worked with that 1. Just searched< yeah, true/false... I can change it. Although, half the usages I've seen in maya pass 0 or 1 there.
There was a problem hiding this comment.
There was a problem hiding this comment.
No wonder it is confusing :) I guess it is all for historical reasons. Putting true here does cost much, so I did.
seando-adsk
approved these changes
Mar 18, 2022
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that caching to USD fails when the Maya prefs are reset.
Also add word-wrap to the descriptions UI.