MAYA-114603 use correct way to query attribute #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct mel command to querythe existence of an attribute. The new code avoids errors being printed in teh MEL console when the attribute does not exists.
|
TY Sean for seeing the issue and suggesting the fix! As a punishment, you review it. :) |
seando-adsk
reviewed
Apr 6, 2022
| @@ -33,7 +33,7 @@ bool hasLoadRulesAttribute(const MFnDependencyNode& depNode) | |||
| { | |||
| MString nodeName = depNode.absoluteName(); | |||
| MString cmd; | |||
| cmd.format("addAttr -query -exists \"^2s.^1s\"", loadRulesAttrName, nodeName); | |||
| cmd.format("attributeQuery -exists -n \"^2s\" \"^1s\"", loadRulesAttrName, nodeName); | |||
There was a problem hiding this comment.
Looks good. FYI, you don't really lines 39/40 as the default value for both these args is false.
seando-adsk
approved these changes
Apr 6, 2022
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct mel command to querythe existence of an attribute. The new code avoids errors being printed in teh MEL console when the attribute does not exists.