MAYA-123016 catch exceptions during notifications #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exception can be thrown by the notified objects or function. Do not let it out as it will crash Maya as nothing else above catches the exceptions.
ppt-adsk
reviewed
May 16, 2022
lib/mayaUsd/ufe/StagesSubject.cpp
Outdated
| @@ -68,6 +68,20 @@ bool isTransformChange(const TfToken& nameToken) | |||
| return nameToken == UsdGeomTokens->xformOpOrder || UsdGeomXformOp::IsXformOp(nameToken); | |||
| } | |||
|
|
|||
| // Prevent exception from the notifications from escaping and breaking USD/Maya. | |||
| // USD does not wrap its notification in try/catch, so we need to do it ourselves. | |||
| template <class RECEIVER> struct SafeNotification | |||
There was a problem hiding this comment.
Can be just a single templated function, doesn't need to be static, we're in the unnamed namespace already:
template<class R, class N> void notify(const N& n) {
// try / catch stuff
R::notify(n);
}
You can then explicitly specify a single template argument and the second template argument (the type of the function argument) will be deduced by the compiler.
There was a problem hiding this comment.
Ah good, I thought that if we provided one template type, we had to provide both, that is why I use this trick to split them.
ppt-adsk
approved these changes
May 17, 2022
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception can be thrown by the notified objects or function. Do not let it out as it will crash Maya as nothing else above catches the exceptions.