MAYA-123332 allow topological modifications #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When locking nodes, it also locks topological modifications. Explicitly re-enable it afterward.
ppt-adsk
reviewed
May 19, 2022
| MDGModifier& dgMod = MDGModifierUndoItem::create("Allow topology modifications"); | ||
|
|
||
| MItDag dagIt; | ||
| dagIt.reset(root, MItDag::kDepthFirst, MFn::kMesh); |
There was a problem hiding this comment.
Seems like a shame that LockNodesUndoItem does a traversal, then we do another traversal here.
There was a problem hiding this comment.
I agree, but I did not see an elegant way out, especially since here we only need meshes.
ppt-adsk
approved these changes
May 19, 2022
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When locking nodes, it also locks topological modifications. Explicitly re-enable it afterward.