Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tremblp/maya 102361/rename fixes #237

Merged
merged 8 commits into from
Feb 11, 2020
Merged

Tremblp/maya 102361/rename fixes #237

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
27769c4
WIP: rename fix support.
ppt-adsk Dec 20, 2019
12889e2
Rework rename command implementation.
ppt-adsk Jan 31, 2020
b4d49f4
Fixed rename undo / redo, and cleaned up for merge.
ppt-adsk Feb 4, 2020
f53f29c
Implemented code review suggestions.
ppt-adsk Feb 6, 2020
e508bdb
Fixed UFE v1 compilation issue.
ppt-adsk Feb 10, 2020
25bac95
Fixed compilation for Maya preview release 112.
ppt-adsk Feb 11, 2020
c0277f0
Fix macOS compilation warning as error.
ppt-adsk Feb 11, 2020
30db4e2
Fixed UFE v1 compilation.
ppt-adsk Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/ufe/UsdStageMap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,12 @@ UsdStageMap g_StageMap;
void UsdStageMap::addItem(const Ufe::Path& path, UsdStageWeakPtr stage)
{
// We expect a path to the proxy shape node, therefore a single segment.
auto nbSegments = path.nbSegments();
auto nbSegments =
#ifdef UFE_V2_FEATURES_AVAILABLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks Pierre.

path.nbSegments();
#else
path.getSegments().size();
#endif
if (nbSegments != 1) {
TF_CODING_ERROR("A proxy shape node path can have only one segment, path '%s' has %d", path.string().c_str(), nbSegments);
return;
Expand Down