Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAYA-123122 remember shared/unshared load state #2398

Merged
merged 4 commits into from
Jun 6, 2022
Merged

MAYA-123122 remember shared/unshared load state #2398

merged 4 commits into from
Jun 6, 2022

Conversation

pierrebai-adsk
Copy link
Collaborator

  • Move and refactor code in proxy shape to avoid code duplication.
  • (There was duplication between shared and unshared case.)
  • Now unshared stage also applied the load state.
  • Add functions to the proxy shape load rule helper class to trigger saving load rules.
  • Save load rules when modifying the loaded state of prims.
  • Refactor the load state commands to share mode code.

@pierrebai-adsk
MAYA-123122 remember shared/unshared load state
7f9c13c 
- Move and refactor code in proxy shape to avoid code duplication.
- (There was duplication between shared and unshared case.)
- Now unshared stage also applied the load state.
- Add functions to the proxy shape load rule helper class to trigger saving load rules.
- Save load rules when modifying the loaded state of prims.
- Refactor the load state commands to share mode code.
@pierrebai-adsk
Copy link
Collaborator Author

The only PF failure is the OSX compiler crashing during the compilation of mayaShaderTranslation.cpp... only for 2022 python 3. Probably an unrelated random crash.

ppt-adsk
ppt-adsk reviewed Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can write a test for this?

lib/mayaUsd/nodes/proxyShapeBase.cpp Outdated Show resolved Hide resolved
@pierrebai-adsk
Copy link
Collaborator Author

Any way we can write a test for this?

Seems doable, I'll write one.

@pierrebai-adsk
MAYA-123122 added unit test
105d930 
Unit test adds a load rule to unload some prims then verify that the load rules are preserved when sharing and unsharing the stage.

Verified that the unit test failed without my changes.
ppt-adsk
ppt-adsk previously approved these changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

@pierrebai-adsk
Copy link
Collaborator Author

Only PF failure is the known Linux interactive image comparison test problem.

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jun 6, 2022
@seando-adsk seando-adsk added the core Related to core library label Jun 6, 2022
@seando-adsk seando-adsk merged commit 5a9b387 into dev Jun 6, 2022
@seando-adsk seando-adsk deleted the t_bailp/MAYA-123122/remember-shared-payload branch June 6, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppt-adsk ppt-adsk ppt-adsk approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
core Related to core library ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierrebai-adsk @ppt-adsk @seando-adsk @ecp-maya-devops-adsk