Provide explicit export options in tests #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide explicit values for export options in open source tests even if they match defaults. This allows tests to pass in environments which run with site-specific export option overrides
pierrebai-adsk
approved these changes
Jun 21, 2022
seando-adsk
added
ready-for-merge
|
Is there anything I need to do to address the Windows build failures or is that a preflight issue? Just wanted to make sure this wasn't waiting on me! |
|
@dj-mcg I've just restarted the preflight. All of our internal preflight issues have been fixed now. So if there is any failure from this run you would need to investigate it. If it passes, then I'll merge. |
seando-adsk
added
the
ready-for-merge
|
@dj-mcg The preflight errors that showed in the last run have been fixed in our internal system. I had started this preflight before the fix was updated in the build system. So I'll consider this preflight a pass and merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide explicit values for export options in open source tests even if
they match defaults. This allows tests to pass in environments which
run with site-specific export option overrides