[al] Check transform values prior to writing to USD. (#993) #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robthebloke
changed the title
robthebloke
changed the title
fowlertADSK
approved these changes
Feb 11, 2020
| @@ -43,6 +43,21 @@ MPxTransformationMatrix* TransformationMatrix::creator() | |||
| return new TransformationMatrix; | |||
| } | |||
|
|
|||
| //---------------------------------------------------------------------------------------------------------------------- | |||
| bool hasEmptyDefaultValue(const UsdGeomXformOp& op, UsdTimeCode time) | |||
There was a problem hiding this comment.
I'm not sure about the actual c++ rule but I always prefer to be explicit and wrap these local functions in an unnamed namespace{}.
Was also thinking that we could just make hasEmptyDefaultValue do everything you have below. It's only used in that exact same chunk of code in the 5 or 6 places. Why not just have it also check "timeCode.IsDefault() && op.GetNumTimeSamples()"
added 2 commits
February 12, 2020 10:40
…#993) * check the TM values prior to writing the data back into USD to prevent duplicate values being written * remove stupid values * added a check to prevent writing of default value if no value was previously specified, and keyframes exist * feedback from code review
robthebloke
force-pushed
the
AL993-check_transform_values_prior_to_writing_to_USD
branch
from
e709662
to
c2ccc0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address two issues when writing data from the Transform nodes to USD (after a TRS tool, or attribute change).