Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration error when GULRAK_SOURCE_DIR is specified on Windows #2551

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

jamestiotio
Copy link
Contributor

This PR fixes issue #2420.

Perhaps @hinton-mgi can test this fix?

Minor note: I am submitting this PR as an individual. I have signed and sent in my Individual CLA form accordingly.

@hinton-mgi
Copy link

I just tested with my build setup. I can confirm it works, and I can do a full rebuild without an internet connection. Thanks.

Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the fix. I've started our internal preflight system on your change.

FYI, we are finalizing the v0.19.0 release right now so merges are temporarily blocked.

@seando-adsk seando-adsk added build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge labels Aug 22, 2022
@seando-adsk seando-adsk merged commit 112fbbc into Autodesk:dev Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants