Fixes for building with gcc 11 (still using old ABI). #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seando-adsk
force-pushed
the
donnels/MAYA-125364/fix_for_gcc11_take2
branch
from
53fce0c
to
74fd234
Compare
seando-adsk
commented
Sep 28, 2022
Comment on lines
-277
to
-281
| # Force the use of ABI version 0 on Linux. | ||
| # This is what Maya has been using for 2019...2023 | ||
| if (${CMAKE_SYSTEM_NAME} MATCHES "Linux") | ||
| list(APPEND setting_list -D_GLIBCXX_USE_CXX11_ABI=0) | ||
| endif() |
There was a problem hiding this comment.
I had previously added this here, where it gets used as a cmake arg. That was incorrect. It is really a "CMAKE_CXX_FLAGS" value.
seando-adsk
force-pushed
the
donnels/MAYA-125364/fix_for_gcc11_take2
branch
from
74fd234
to
e6ce3f0
Compare
ppt-adsk
approved these changes
Sep 28, 2022
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.