Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-125991 - Unable to switch variants when Session Layer is targeted #2698

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

vlasovi
Copy link
Collaborator

@vlasovi vlasovi commented Nov 2, 2022

No description provided.

pierrebai-adsk
pierrebai-adsk previously approved these changes Nov 2, 2022
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to think if your simple solution would not work in some case but could not imagine any. (famous last words, I know.) Good work.

@pierrebai-adsk
Copy link
Collaborator

Oh, just one thing: could a unit test be created to test this?

@vlasovi
Copy link
Collaborator Author

vlasovi commented Nov 3, 2022

@seando-adsk The preflight failure is due to an internal build system issue and not to the PR. This can be merged.

@vlasovi vlasovi added the ready-for-merge Development process is finished, PR is ready for merge label Nov 3, 2022
@seando-adsk seando-adsk added the ufe-usd Related to UFE-USD plugin in Maya-Usd label Nov 3, 2022
@seando-adsk seando-adsk merged commit 2d48d83 into dev Nov 3, 2022
@seando-adsk seando-adsk deleted the vlasovi/MAYA-125991 branch November 3, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants