MAYA125953 worldspace flag for Maya USD export #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Nov 8, 2022
pierrebai-adsk
commented
- Added -worldspace flag to the mayaUSDExport command.
- Added worldspace flag to the UsdMayaJobExportArgs structure.
- Added worldspace to the UsdMayaJobExportArgsTokens.
- Added docs about worldspace flag to the commands read-me.
- Added default value for the worldspace flag in UsdMayaJobExportArgs.
- Added worldspace parsing to UsdMayaJobExportArgs.
- Added worldspace flag to the Python wrapper.
- Added worldspace flag default to the Python default dict.
- Fixed the extractVector template function to not be exported since it is inlined.
- Fixed the UsdMayaExportTranslator to use the root prim options the same way the export command does.
- Added worldspace flag to the export UI.
- Don't assume that all new channels have unique names when making their names unique.
- Walk up the DAG stack to generate the channels for all ancestors when using worldspace flag.
- Separate channel generation from writing the xform op, to support recursion to generate ancestor.
- Added tests for the worldspace flag in the unit tests.
- Added -worldspace flag to the mayaUSDExport command. - Added worldspace flag to the UsdMayaJobExportArgs structure. - Added worldspace to the UsdMayaJobExportArgsTokens. - Added docs about worldspace flag to the commands read-me. - Added default value for the worldspace flag in UsdMayaJobExportArgs. - Added worldspace parsing to UsdMayaJobExportArgs. - Added worldspace flag to the Python wrapper. - Added worldspace flag default to the Python default dict. - Fixed the extractVector template function to not be exported since it is inlined. - Fixed the UsdMayaExportTranslator to use the root prim options the same way the export command does. - Added worldspace flag to the export UI. - Don't assume that all new channels have unique names when making their names unique. - Walk up the DAG stack to generate the channels for all ancestors when using worldspace flag. - Separate channel generation from writing the xform op, to support recursion to generate ancestor. - Added tests for the worldspace flag in the unit tests.
pierrebai-adsk
added
enhancement
pierrebai-adsk
commented
Nov 8, 2022
| @@ -269,9 +269,6 @@ void UsdMayaTransformWriter::_MakeAnimChannelsUnique(const UsdGeomXformable& usd | |||
| existingOps.emplace(op.GetOpName()); | |||
| } | |||
|
|
|||
| if (existingOps.size() == 0) | |||
| return; | |||
There was a problem hiding this comment.
This was assuming that new channels all had different names, which is incorrect when the world-space flag is used as multiple transforms from ancestors can be generated.
|
Jerry, if you are too busy, I could ask someone else from our team, but you are the export expert, so I chose you by default. |
JGamache-autodesk
approved these changes
Nov 8, 2022
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.