MAYA-125723 - Implement display layer's bbox mode for instanced geometry #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he use of the newly introduced, internal representation forcedBBox
| { | ||
| ReprVector::const_iterator it | ||
| = std::find_if(reprs.begin(), reprs.end(), [reprToken](ReprVector::const_reference e) { | ||
| return reprToken == e.first; |
There was a problem hiding this comment.
I suppose the vector is not sorted so std::binary_search cannot be used.
There was a problem hiding this comment.
Those are stored in an RPrim and managed by Hydra. They are not sorted.
|
|
||
| // Instanced primitives with instances in display layers use 'forced' representations to | ||
| // draw those specific instances, so the 'forced' representations should be inited alongside | ||
| if (reprToken != HdVP2ReprTokens->forcedBbox) { |
There was a problem hiding this comment.
inited -> initialized, but not worth making a new commit just for that.
| return reprToken == e.first; | ||
| }); | ||
| HdReprSharedPtr curRepr = (it != reprs.end() ? it->second : nullptr); | ||
| // Find the current representation in the array of all inited representations |
There was a problem hiding this comment.
Same inited -> initialized, again not worth a commit.
| HdSceneDelegate* delegate, | ||
| HdRenderParam* renderParam, | ||
| HdDirtyBits* dirtyBits, | ||
| ReprVector const& reprs); |
There was a problem hiding this comment.
I'd like to have some docs/comment that explain what each function does and why. I guess it falls into a larger scope of documenting how the render delegates work.
pierrebai-adsk
approved these changes
Nov 8, 2022
vlasovi
added
vp2renderdelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.