Shorten nice names by trimming schema name #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some attribute names use namespaces that are copies of the schema name. When displaying UI names we want to strip that redundant information.
|
Before and after for an exported spotlight: |
|
Before and after for a shading node with a NodeGraph API applied: |
feldstj
requested changes
Jan 12, 2023
| # will return ["CollectionAPI:instance1","CollectionAPI:instance2"] but we want to group | ||
| # both instance inside a "CollectionAPI" section. | ||
| # We do not group the collections API. We rather create a section that | ||
| # includes the instance in the title. This allows up to optimally trim |
| prefix = prefix.substr(0, dunderPos) + typeNameAndInstance.second.GetString() | ||
| + ":"; | ||
|
|
||
| // If the parameter name does not start with the templte, it does not belong to |
|
Pretty cool change. Just a few minor spelling issues. |
feldstj
approved these changes
Jan 12, 2023
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. |
seando-adsk
approved these changes
Jan 13, 2023
seando-adsk
deleted the
gamaj/strip_api_schema_name_from_attribute_nice_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some attribute names use namespaces that are copies of the schema name. When displaying UI names we want to strip that redundant information.