MAYA-127404 sub-layers relative to their parent #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Feb 16, 2023
pierrebai-adsk
commented
- Handle making the root layer relative to the scene when converting anonymous layers.
- Added a helper class to change the current directory temporarily.
- Added getLayerFileDir helper to get the directory containing a given layer.
- Added getPathRelativeToLayerFile helper to make a path relative to a layer.
- Added prepareLayerSaveUILayer helper to prepare the UI to save layers in case the paths need to be relative.
- AddedrequireUsdPathsRelativeToParentLayer helper to verify if paths should be relative to a parent layer.
- Updated saveAnonymousLayer helper function to handle saving sub-layers relative to their parent.
- Added a parentLayer function to the LayerTreeItem to retrieve the parent layer, if any.
- Added support to save layer relative to their parent in the LayerTreeItem::saveAnonymousLayer function.
- Changed the saveLayerUI interface function to take the parent layer, so that sub-layer can be made relative to their parent if needed.
- Changed SaveLayersDialog::saveLayerFilePathUI to accept the parent layer and passing it to the UI.
- Updated SaveLayerPathRow::onOpenBrowser to handle saving sub-layers relative to the parent.
- Added MEL script code for the UI to support saving sub-layer relative to their parent layer.
- Added Python usdSubLayerFileRelative class to implement the save layer UI for saving sub-layers relative to their parent.
- Updated context menu to use the new functions.
- Replace the sub-layer in its parent using multiple possible identifiers.
- Make sure to use the desired file path form (absolute or relative) when replacing the sub-layer in its parent.
- Temporarily modify the current directory when initially loading the sub-layer.
- Handle making the root layer relative to the scene when converting anonymous layers. - Added a helper class to change the current directory temporarily. - Added getLayerFileDir helper to get the directory containing a given layer. - Added getPathRelativeToLayerFile helper to make a path relative to a layer. - Added prepareLayerSaveUILayer helper to prepare the UI to save layers in case the paths need to be relative. - AddedrequireUsdPathsRelativeToParentLayer helper to verify if paths should be relative to a parent layer. - Updated saveAnonymousLayer helper function to handle saving sub-layers relative to their parent. - Added a parentLayer function to the LayerTreeItem to retrieve the parent layer, if any. - Added support to save layer relative to their parent in the LayerTreeItem::saveAnonymousLayer function. - Changed the saveLayerUI interface function to take the parent layer, so that sub-layer can be made relative to their parent if needed. - Changed SaveLayersDialog::saveLayerFilePathUI to accept the parent layer and passing it to the UI. - Updated SaveLayerPathRow::onOpenBrowser to handle saving sub-layers relative to the parent. - Added MEL script code for the UI to support saving sub-layer relative to their parent layer. - Added Python usdSubLayerFileRelative class to implement the save layer UI for saving sub-layers relative to their parent. - Updated context menu to use the new functions. - Replace the sub-layer in its parent using multiple possible identifiers. - Make sure to use the desired file path form (absolute or relative) when replacing the sub-layer in its parent. - Temporarily modify the current directory when initially loading the sub-layer.
vlasovi
reviewed
Feb 24, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
previously approved these changes
Feb 28, 2023
Co-authored-by: Sean Donnelly <[email protected]>
Co-authored-by: Sean Donnelly <[email protected]>
vlasovi
previously approved these changes
Mar 1, 2023
|
@seando-adsk I believe I made all requested changes. |
vlasovi
approved these changes
Mar 7, 2023
seando-adsk
reviewed
Mar 8, 2023
seando-adsk
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.