Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAYA-106352 keep hierarchy window on top of import window #2892

Merged
merged 5 commits into from
Feb 28, 2023
Merged

MAYA-106352 keep hierarchy window on top of import window #2892

merged 5 commits into from
Feb 28, 2023

Conversation

pierrebai-adsk
Copy link
Collaborator

  • Add a flag to the UsdImportDialog command to specify the parent window name.
  • Use that flag when invoking the command from the import panel.
  • Use the flag in the command to find the parent window.

@pierrebai-adsk
MAYA-106352 keep hierarchy window on top of import window
4b40946 
- Add a flag to the UsdImportDialog command to specify the parent window name.
- Use that flag when invoking the command from the import panel.
- Use the flag in the command to find the parent window.
@pierrebai-adsk pierrebai-adsk added enhancement New feature or request adsk Related to Autodesk plugin import-export Related to Import and/or Export labels Feb 20, 2023
@pierrebai-adsk
Copy link
Collaborator Author

Unit test testUsdExportPackage randomly failed again on a single Windows platform, all other platforms and tests passed.

vlasovi
vlasovi previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@vlasovi vlasovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pierrebai-adsk
MAYA-106352 improve code to find parent window
07d6450 
- Pass the panel name to the USDImportCommand.
- The command will find the closest parent window of the UI element given.
- If not found, the main window is used.
seando-adsk
seando-adsk approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 23, 2023
@seando-adsk seando-adsk merged commit d043264 into dev Feb 28, 2023
@seando-adsk seando-adsk deleted the bailp/MAYA-106352/hierarchy-view-on-top branch February 28, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seando-adsk seando-adsk seando-adsk approved these changes

@vlasovi vlasovi vlasovi approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
adsk Related to Autodesk plugin enhancement New feature or request import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierrebai-adsk @seando-adsk @vlasovi @ecp-maya-devops-adsk