- Enable C++11 for GoogleTest external project for sake of consistency with the project. #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y with the project. - I also pumped the CMake Min version to 3.12.0 and removed CMAKE_MACOSX_RPATH flag as is no longer needed.
ppt-adsk
approved these changes
Feb 18, 2020
kxl-adsk
added
the
do-not-merge-yet
…needs to be explicitly called.
kxl-adsk
removed
the
do-not-merge-yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also bumped the CMake Min version to 3.12.0 and removed CMAKE_MACOSX_RPATH flag as is no longer needed.