Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var MAYAUSD_VP2_USE_ONLY_PREVIEWSURFACE #2908

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

JGamache-autodesk
Copy link
Collaborator

This env var forces using UsdPreviewSurface shading for VP2.

Fixes #2637.

This env var forces using UsdPreviewSurface shading for VP2.

Fixes #2637.
Copy link
Collaborator

@vlasovi vlasovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better name for this env var would have been MAYAUSD_VP2_ALLOW_MATERIAlX, but otherwise looks good

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 28, 2023
@JGamache-autodesk
Copy link
Collaborator Author

@seando-adsk Ready for merge.

MaterialX is allowed by default, so negative env var works better to express the requirement.

@seando-adsk seando-adsk merged commit d075edb into dev Feb 28, 2023
@seando-adsk seando-adsk deleted the gamaj/env_var_to_deactivate_materialx branch February 28, 2023 21:26
@Lucas3Dspain
Copy link

is there a doc where we have all these kinds of env vars? I see some of them in lib/mayaUsd/commands/Readme.md
I'm worried about people not knowing they are available.

@JGamache-autodesk
Copy link
Collaborator Author

The most interesting part is that they can be found directly in this public repo and the TF_DEFINE_ENV_SETTING syntax requires a description string. We are indeed a bit behind since there is no official documentation on the dozen of env settings this query finds in the Adsk plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
materials ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable MaterialX
5 participants