MAYA-128211 block command when layers are muted #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is at least one muted layers, block the delete, rename, group and reparent commands. These are commands that re-organize the hierarchy and must thus affect all layers with opinions. When some of these layers are muted, they would not be able to be updated with the new prim path, thus we prevent the operation. Add unit tests for the commands. Note that reparent and group are composite commands using the same underlying command (insert child) and thus require only one test.
pierrebai-adsk
added
bug
|
Note PF only failed in one OSX instance which timeout, but that particular platform passed in a previous attempt, so it was only a glitch. |
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is at least one muted layers, block the delete, rename, group and reparent commands. These are commands that re-organize the hierarchy and must thus affect all layers with opinions. When some of these layers are muted, they would not be able to be updated with the new prim path, thus we prevent the operation.
Add unit tests for the commands. Note that reparent and group are composite commands using the same underlying command (insert child) and thus require only one test.