Added applyEulerFilter to import #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang-format Updated skeletal import Updated copyright
pierrebai-adsk
previously approved these changes
Mar 20, 2023
|
@tryptik Unfortunately the clang-format step (of the preflight) failed. Can you please make the changes and I'll re-run the preflight again. |
added 2 commits
March 22, 2023 18:34
|
I have run the clang formatter and removed some older code fragments from a previous implementation. |
pierrebai-adsk
previously approved these changes
Mar 23, 2023
|
@tryptik Unfortunately the clang-format step failed again. If you are running it locally make sure you are using v10.0.0. |
pierrebai-adsk
approved these changes
Mar 29, 2023
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has proven useful to allow the Euler filtering of rotational animation on import as well as export. This P/R adds a flag
aef/applyEulerFilterflag tomayaUSDImportthat applies Euler filtering for transform and skeletal animation data.