MAYA-114041 - As a user, I'd like my pulled Maya object to inherit visibility #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Remember the path for which we are accumulating the callbacks | ||
| MDagPath ancestorPath; | ||
| MDagPath::getAPathTo(obj, ancestorPath); | ||
| _ancestorCallbacksPath = ancestorPath.fullPathName(); |
There was a problem hiding this comment.
What will happen if the proxy shape node is renamed? Or any of its ancestors are renamed?
There was a problem hiding this comment.
I just tested: renaming proxy shape node or any of its DAG ancestors works fine, as in this case we call updateAncestorCallbacks on the next dirty callback. However, after renaming a USD ancestor of a pulled node we loose the connection inside ProxyAcessors and this is a general problem that exists for all proxy accessors, including relaying the 3d transform. I think we may need to create a Jira ticket for that one.
pierrebai-adsk
previously approved these changes
Mar 23, 2023
…validation - Fixing proxy accessor autotests by doing strict filtering of dirty plugs.
- Fixing build for older Mayas
pierrebai-adsk
approved these changes
Mar 29, 2023
vlasovi
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom attribute "combinedVisibility" to proxy accessors to output combined visibility to maya pulled prims