MAYA-126040 improve preventing edits #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Mar 29, 2023
pierrebai-adsk
commented
- Add documentations about edit routing.
- Make attribute editing not throw exception for now to avoid possibly destabilizing Maya.
- Instead, attribute commands return null command when edits are prevented.
- Make the commands use the pre-delcraed USD tokens (code cleanup)
- Make the visibility command always apply routing by moving routing code in its constructor.
- Add more unit test for edit routing, testing more commands.
- Add more unit tests for command prevention
- Add documentations about edit routing. - Make attribute editing not throw exception for now to avoid possibly destabilizing Maya. - Instead, attribute commands return null command when edits are prevented. - Make the commands use the pre-delcraed USD tokens (code cleanup) - Make the visibility command always apply routing by moving routing code in its constructor. - Add more unit test for edit routing, testing more commands. - Add more unit tests for command prevention
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.