Updated Sub layer dialog to display the correct relative path when enabled. #2990
Conversation
|
@pierrebai-adsk Can you have a look at these changes as well? You have done most of the relative path work. |
|
@AramAzhari-adsk If only the comment in the .py file is removed, there is no need to re-run the preflight again. |
| .staticmethod("getPathRelativeToMayaSceneFile"); | ||
| scope s | ||
| = class_<UsdMayaUtilScope>("Util", no_init) | ||
| .def("IsAuthored", UsdMayaUtil::IsAuthored) |
There was a problem hiding this comment.
For the life of me, I cannot figure out why clang-format decided all this needed to be reformatted. The rules are so obscure!
|
|
||
| if (!relativePathAndSuccess.second) { | ||
| TF_WARN( | ||
| "File name (%s) cannot be resolved as relative to its parent layer directory (%s), " |
There was a problem hiding this comment.
This function is general, so I would think we should not mention "parent layer" in the error, just "target directory" maybe? (It's not "parent" either since it failed to be made relative...)
| @@ -77,6 +77,12 @@ MAYAUSD_CORE_PUBLIC | |||
| std::pair<std::string, bool> | |||
| makePathRelativeTo(const std::string& fileName, const std::string& relativeToDir); | |||
|
|
|||
| /*! \brief returns relative path of a layer file to its parent layer's directory | |||
| */ | |||
There was a problem hiding this comment.
Same here, the doc should not refer to layer, IMO.
|
@pierrebai-adsk I took notes and will keep a commit to be checked in in the future alongside refactors / relative path work. |
AramAzhari-adsk
added
the
ready-for-merge
seando-adsk
deleted the
azharia/MAYA-128453/sublayer-file-browser-unresolved-path-fix
branch
No description provided.