Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-128070 - Update for USD v23.02 #3025

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

seando-adsk
Copy link
Collaborator

MAYA-128070 - Update for USD v23.02

  • Add Maya location to LD_LIBRARY_PATH for executable tests.

* Add Maya location to LD_LIBRARY_PATH for executable tests.
@seando-adsk seando-adsk added the unit test Related to unit tests (both python or c++) label Apr 17, 2023
# Necessary for tests like DiffCore to find python lib since the test
# is an exectuable and running on its own (not with maya/mayapy).
# See DYLD_LIBRARY_PATH case below.
list(APPEND MAYAUSD_VARNAME_LD_LIBRARY_PATH "${MAYA_LOCATION}/lib")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to add this for the bump of Maya PR to USD v23.02. I'm not sure why but a few of the tests (such as DiffCore which is a standalone executable test) cannot find python3.10.so (which comes from Maya). So I added the Maya lib folder to LD_LIBRARY_PATH for these types of test only (have COMMAND set). The same thing was done for Mac a while ago.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be necessary since my last fix in Maya, but it might be another situation so if it is a simple fix like that, it is ok.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These standalone (executable) tests don't run using maya or mayapy. So the USD libs that link with boost python (for the python bindings) cannot find the python 3.10.so.

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Apr 18, 2023
@seando-adsk seando-adsk merged commit 1b88864 into dev Apr 18, 2023
@seando-adsk seando-adsk deleted the donnels/MAYA-128070/update_for_usd_23_02 branch April 18, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants