Added save / restore to preserve object selection after Undoing Remove SubLayer #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AramAzhari-adsk
added
bug
seando-adsk
reviewed
Apr 26, 2023
| @@ -278,8 +280,44 @@ class InsertRemoveSubPathBase : public BaseCmd | |||
| } | |||
| } | |||
|
|
|||
| void saveSelection() | |||
There was a problem hiding this comment.
Are these just a copy/paste of the functions below in the MuteLayer command? If so please refactor them out either into BaseCmd or just helpers in an unnamed namespace. I guess the input to the function will be the proxyShapePath.
There was a problem hiding this comment.
I was hoping to have another pass as a refactor task and go through all commands in that file and assess which ones need the selection store / restore. I have seen similar code in AL USD so this might be good to go into a global location that can be used from various UI.
There was a problem hiding this comment.
@seando-adsk I made a follow up ticket for this request MAYA-129060 . Thank you.
seando-adsk
added
the
ready-for-merge
seando-adsk
deleted the
azharia/MAYA-109678/Fixes-Object-Selection-When-Undoing-A-SubLayer-Remove
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added save / restore to preserve object selection after Undoing Remove SubLayer