MAYA-128594 - Imported displayOpacity are not interpreted correctly #3071
Conversation
| // data | ||
| if (colorSetRep == MFnMesh::kRGB) { | ||
| exportDisplayOpacity = true; | ||
| } |
There was a problem hiding this comment.
Should there be a pre-pass to detect this? The code as written seems to depends on the order of the color set?
There was a problem hiding this comment.
Yes. If we can export DisplayOpacity separately actually depends on the type of DisplayColor. If the display color is in RGBA format (which means it contains alpha, aka opacity, already), then we can't export the DisplayOpacity. However if the color is in RGB format (no alpha data), we can safely export the opacity, and this should be the only scenario we export DisplayOpacity
There was a problem hiding this comment.
Yes, but as I understand the code, the flag exportDisplayOpacity is set to true within the same loop where it is checked. So the behaviour depends on the order the color set names are encountered in this loop, which seems to me to be arbitrary?
In short, if the flags gets sets after DisplayOpacityColorSetName has already been processed, then it won't use the opacity even though the flag is now true.
That is why I suggested that the flag be set in a separate loop that would run before, so that it is certain to be set to the correct value when the opacity color set is encountered.
I may be wrong, if so I'd like to know where my reasoning is incorrect.
There was a problem hiding this comment.
Oh I see. Let me look into that
…/MAYA-128594/display-opacity-export
samuelliu-adsk
dismissed stale reviews from seando-adsk and pierrebai-adsk
via
bcb480e
samuelliu-adsk
added
the
ready-for-merge
No description provided.