MAYA-129538 move commands out of context op implementation #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the commands that implement the menu items in their own file as reusable UFE commands. - Fix undo of add reference and payload that were adding a delete to the prim lists instead of reverting the addition. - Wrap all move commands in Python - Add unit test for all commands that were moved into their own file. - Chang all commands to use UsdUndoableItem and UsdUndoBlock to ensure perfect undo.
seando-adsk
previously requested changes
Jun 22, 2023
Comment on lines
202
to
203
| //! \brief Create a working Material and select it: | ||
| class InsertChildAndSelectCommand : public Ufe::CompositeUndoableCommand |
There was a problem hiding this comment.
Any reason this command wasn't moved to a separate file?
There was a problem hiding this comment.
It seemed a very specific combination of two commands for the context menu. I could move it.
There was a problem hiding this comment.
The explanation makes sense. If its not reusable then leave it in ContextOps
- Fix copyright years, - Fix header inclusion guards to not use pragma once. - Move implementation of a function to its own file. - Put the common text filtering test helper in the usdUtils file. - Modify tests to use the common function.
pierrebai-adsk
added
adsk
pierrebai-adsk
dismissed
seando-adsk’s stale review
Sean is in vacation and I addressed all his comments
In UFE v2, the insert-child command is declared in the hiearchy.h header.
AramAzhari-adsk
approved these changes
Jun 28, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
removed
adsk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the commands that implement the menu items in their own file as reusable UFE commands.