EMSUSD-251 - Release all refs held by session state on reset #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,6 +118,7 @@ void MayaLayerEditorWindow::onClearUIOnSceneReset() | |||
| LayerTreeModel::suspendUsdNotices(true); | |||
| setCentralWidget(nullptr); | |||
| delete _layerEditor; | |||
| _sessionState.setStageEntry(UsdLayerEditor::SessionState::StageEntry{}); | |||
There was a problem hiding this comment.
The stage entry was holding a ref on the stage, which prevented it from being fully released on File->Open. If re-opening the same file or a file referencing the same stage, the leak caused any unsaved modifications to outlive the File->Open action.
seando-adsk
approved these changes
Jul 5, 2023
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk ready for merge. Thanks! |
seando-adsk
deleted the
gamaj/EMSUSD-251/release_layer_editor_refs_on_open_and_new
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.