EMSUSD-256 allow Maya ref to be relative to the layer. #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Jul 18, 2023
pierrebai-adsk
commented
- Prepare the current edit target before showing the file dialog.
- Make the function used for this preparatio clearer by naming the flag passed to disable the option for using the scene file as the relative root. When making things relative to the edit target, we don't want to accidentlly use the scene as the root when no saved layer exist.
- Make the code creating the dialog for Maya ref use the code to make the path relative.
- Change the label of the seperator in the file dialog.
- Refactor the common Python code to avoid passing around some options and at teh same time make the function override have the same parameters. Having the same paarmeters is necessary since differnt classes will end-up calling different functions with the same parameters.
- Split the code that create the relative path UI in two: one to setup the layout, one for the UI elements.
- This was necessary because the dialog for the Maya ref already setup the layout.
- Create new class for Maya ref relative UI.
pierrebai-adsk
added
enhancement
seando-adsk
previously approved these changes
Jul 28, 2023
There was a problem hiding this comment.
I have an PR #3248 which is moving ContextOps to UsdUfe. The change you made will be in the new MayaUsdContextOps.cpp (in the mayausd/ufe folder). If you don't mind I would like to merge mine first and then you will probably have to merge in latest dev.
- Prepare the current edit target before showing the file dialog. - Make the function used for this preparation clearer by naming the flag passed to disable the option for using the scene file as the relative root. When making things relative to the edit target, we don't want to accidentlly use the scene as the root when no saved layer exist. - Make the code creating the dialog for Maya ref use the code to make the path relative. - Change the label of the seperator in the file dialog. - Refactor the common Python code to avoid passing around some options and at teh same time make the function override have the same parameters. Having the same paarmeters is necessary since differnt classes will end-up calling different functions with the same parameters. - Split the code that create the relative path UI in two: one to setup the layout, one for the UI elements. - This was necessary because the dialog for the Maya ref already setup the layout. - Create new class for Maya ref relative UI. - Make the description not collapsable.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-256/relative-maya-ref
branch
from
159de82
to
2ba2e71
Compare
seando-adsk
approved these changes
Jul 28, 2023
AramAzhari-adsk
approved these changes
Jul 28, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.