EMSUSD-671 fix reloading scene with layers saved in the Maya scene #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
bug
When reloading a scene that contained layers serialized directly in the scene, sub-layers would be lost because they were anonymous layers but on reload that status was lost and the sub-layer would be lost whenever the stage got recomputed. Fix this by remembering that the sub-layer are anonymous on reload. Add unit test to verify lost layer fix - Add comments to the layer manager serialization test and fix the layer being targeted. - Refactor common code in proxy shape saving tests. - Add more checks in the proxy shape saving test to verify that the contents are correct afetr reload and after recompute.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-671/fix-lost-layers
branch
from
6f415a2
to
b8672f5
Compare
pierrebai-adsk
commented
Dec 14, 2023
pierrebai-adsk
commented
Dec 14, 2023
pierrebai-adsk
commented
Dec 14, 2023
AramAzhari-adsk
approved these changes
Dec 20, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reloading a scene that contained layers serialized directly in the scene, sub-layers would be lost because they were anonymous layers but on reload that status was lost and the sub-layer would be lost whenever the stage got recomputed.
Fix this by remembering that the sub-layer are anonymous on reload.
Add unit test to verify lost layer fix