clean up part1 #369
Merged
clean up part1 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra other than declaring their dependence on mayaUsd.
mayaUsd target now declares ${CMAKE_BINARY_DIR}/include publicly.
mattyjams
approved these changes
Mar 21, 2020
There was a problem hiding this comment.
Sweet! Yeah, looks great to me! Thanks @HamedSabri-adsk! And thanks also for the focused PR! Super easy to review. :)
|
Thanks both @mattyjams @elrond79 . Glad it works. |
HamedSabri-adsk
merged commit 69727dc
into
sabrih/MAYA-103365/cleanup_mtoh_hdmaya_cmake
JGamache-autodesk
pushed a commit
that referenced
this pull request
Mar 28, 2023
See if MayaUSD can work without cot-psl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was planning to bring over this PR a bit later but since there has a been a lot of confusion around this I decided to do it now to clarify things.
What is the point of this PR?
targets linking against
mayaUsdlibrary don't need to do anything extra other than declaring their dependence on mayaUsd. mayaUsd target now declares ${CMAKE_BINARY_DIR}/include publicly.This change is based on earlier concern from @mattyjams and it makes sense to me. I hope it makes things more clear.
e.g
before:
after: