upgrade maya-usd project to the C++14 standard #438
Conversation
Conforming to VFX Reference Platform CY2018+ and following suit from core USD, this change sets the maya-usd project to use the C++14 standard if we're either building for Maya 2019 or later, or if we're building against USD 20.05 or later. Core USD moved to C++14 with release 20.05 in this commit: PixarAnimationStudios/OpenUSD@afc0d5e
cmake/defaults/CXXDefaults.cmake
Outdated
| # building against USD 20.05 or later. Otherwise require C++11. | ||
| if ((MAYA_APP_VERSION VERSION_GREATER_EQUAL 2019) OR | ||
| ((DEFINED USD_VERSION_NUM) AND | ||
| (USD_VERSION_NUM VERSION_GREATER_EQUAL 2005))) |
There was a problem hiding this comment.
@mattyjams Just 1 minor thing, do we really need (DEFINED USD_VERSION_NUM)? Why do we need to check for it?
There was a problem hiding this comment.
Yeah, I was a little wary of that myself, but we already had something similar lower in that file:
maya-usd/cmake/defaults/CXXDefaults.cmake
Line 49 in 11b87a9
It looks like it's technically possible to make it out of FindUSD.cmake without having gotten a value for USD_VERSION_NUM:
maya-usd/cmake/modules/FindUSD.cmake
Line 102 in 11b87a9
Maybe that's the case for especially old releases of USD? I can't remember when that was added.
There was a problem hiding this comment.
Not a biggie at all but I believe it is safe to not check for this and the reason is that this variable always exist as part of logic that you showed me in FindUSD.cmake. This variable was introduced by Paul ( 848de8f ) back in October of last year.
The reason I brought was because for certain variables ( e.g UFE_PREVIEW_VERSION_NUM ), we do want to check because they simply don't exist when building against certain version of things.
See my comments here:
Cheers.
There was a problem hiding this comment.
Right, but since USD_VERSION_NUM is only set inside an if() block, it's technically possible for it not to be set:
maya-usd/cmake/modules/FindUSD.cmake
Line 93 in 11b87a9
It would admittedly have to be for the pretty bizarre reason that pxr/pxr.h was missing even though USD_INCLUDE_DIR is set, since the find_package_handle_standard_args() call validates USD_INCLUDE_DIR. The build is likely to fail in some spectacular way if that's the case.
I can add USD_VERSION and USD_VERSION_NUM as REQUIRED_VARs to find_package_handle_standard_args() and remove the defined() checks? It might be better anyway if we fail faster during CMake config, as that would hopefully be easier to diagnose than some incomprehensible compile failure later on.
There was a problem hiding this comment.
Cool, that makes sense to me. Good call!
There was a problem hiding this comment.
Awesome! Thank you again for quick respond.
These CMake variables are used in many places throughout the code base, so the build is likely to break in ways that would be difficult to decipher if they happen to be undefined. This change marks them as required so that the failure occurs sooner and can be debugged more easily.
USD_VERSION_NUM is now a required variable from FindUSD.cmake, so there is no longer a need to check whether it is defined before using it.
* Run mesh tests in mesh adapter mode. * Added mesh adapter test capability, and refactored test case base classes.
Re-opening this from the original #395 pull request...
Conforming to VFX Reference Platform CY2018+ and following suit from core USD, this change sets the maya-usd project to use the C++14 standard if we're either building for Maya 2019 or later, or if we're building against USD 20.05 or later.
Core USD moved to C++14 with release 20.05 in this commit:
PixarAnimationStudios/OpenUSD@afc0d5e