updates from Hdx de-boostification and Hd reorganization #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation This change corresponds to the following core USD commits: PixarAnimationStudios/OpenUSD@f3e58ef PixarAnimationStudios/OpenUSD@e67ea8d (Internal changes: 2056594, 2056628)
Texture sampling related enums in Hydra were moved from hd/enums.h to hd/types.h, so this change ensures that hdMaya includes the header that defines them to protect against further Hydra header reorganization. This change corresponds to core USD commit PixarAnimationStudios/OpenUSD@2302bda (Internal change: 2057373)
|
@mattyjams We just adopted 20.05 and will stay for a few weeks on it while we deal with python3. I see HDX_API_VERSION guards - we shouldn't have any issue in merging this change even without adopting the latest dev branch? FWIW. we will have to validate that everything works on our end with the latest dev branch before merging. |
|
@kxl-adsk: Yeah, that's right. The |
kxl-adsk
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two recent post-20.05 commits in core USD made some Hdx pointer types use std::shared_ptr instead of boost::shared_ptr, and a third commit moved some Hd enum values from hd/enums.h to hd/types.h.
The changes here update the maya-usd code to account for these core USD commits.