MAYA-104544 Handle changing the USD stage #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ete everything and clear the subscene container.
williamkrick
requested review from
huidong-chen and
kxl-adsk
and removed request for
huidong-chen
|
The changes I've done aren't perfect. In some cases when I load a new usd stage some of the old stage keeps on drawing in the viewport. Looking at the documentation for MPxSubSceneOverride it seems like clearing the MSubSceneContainer should be enough to prevent anything from the old stage from drawing, so I'm guessing there is still a bug in Maya which is causing that problem. I'll wait until @HdC-adsk makes some progress on the drawing issues he's looking at before tackling this additional issue, in case they are duplicates. |
kxl-adsk
reviewed
Apr 29, 2020
kxl-adsk
suggested changes
Apr 30, 2020
huidong-chen
approved these changes
Apr 30, 2020
kxl-adsk
reviewed
Apr 30, 2020
huidong-chen
approved these changes
Apr 30, 2020
kxl-adsk
reviewed
May 1, 2020
seando-adsk
approved these changes
May 1, 2020
kxl-adsk
approved these changes
May 1, 2020
pilarmolinalopez
approved these changes
May 1, 2020
kxl-adsk
deleted the
krickw/MAYA-104544/update_the_cached_usdStage_if_it_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cached usdStage in the proxyRenderDelegate can change. If that happens delete everything cached in the ProxyRenderDelegate and clear the subscene container so VP2 draws correctly.