Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-105123 wait for build to start, then wait for completion and pos… #590

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

smithw-adsk
Copy link
Collaborator

…t results

@smithw-adsk smithw-adsk added the do-not-merge-yet Development is not finished, PR not ready for merge label Jun 15, 2020
# Wait for remote build to start
- name: Wait until remote build starts
shell: bash
# 1080 = 180 minutes in 10 second increments. There will be overhead for the git pull command, so wait time will be more than 180 minutes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the end-user perspective, I don't really care if this sleep will be 10 seconds or 1 minute. How about we reduce the frequency of these calls?

BTW. Typically we count the time that is elapsed, not the number of iterations. Is this something hard to achieve here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. 1-minute sleeps is vastly more intuitive. I'll add that now.

We could be more precise with the timing, but I think the rough count is sufficient for the timeout purpose.

@kxl-adsk kxl-adsk removed the do-not-merge-yet Development is not finished, PR not ready for merge label Jun 18, 2020
@kxl-adsk kxl-adsk merged commit 819ce49 into dev Jun 22, 2020
@kxl-adsk kxl-adsk deleted the smithw/MAYA-105123/improved-messaging branch June 22, 2020 17:16
@kxl-adsk kxl-adsk added the build Related to building maya-usd repository label Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants