Fix naming a prim to something that contains an invalid character crashes Maya #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…character crashes Maya
kxl-adsk
suggested changes
Jul 7, 2020
kxl-adsk
added
ufe-usd
ppt-adsk
reviewed
Jul 7, 2020
ppt-adsk
reviewed
Jul 7, 2020
test/lib/ufe/testRename.py
Outdated
Comment on lines
343
to
344
| snIter = iter(ufe.GlobalSelection.get()) | ||
| pSphereItem = next(snIter) |
There was a problem hiding this comment.
Since rename is UFE v2 only, you can just use Ufe::Selection::front():
pSphereItem = ufe.GlobalSelection.get().front()
test/lib/ufe/testRename.py
Outdated
| pSphereItemRenamed = str(pSphereItem.path().back()) | ||
|
|
||
| # get the prim | ||
| usdPrim = stage.GetPrimAtPath('/sphereXform/' + pSphereItemRenamed) |
There was a problem hiding this comment.
That would be just
usdPrim = stage.GetPrimAtPath(str(pSphereItem.path().segments[1]))
There was a problem hiding this comment.
please see a036874
test/lib/ufe/testRename.py
Outdated
Comment on lines
355
to
359
| # rename | ||
| try: | ||
| primspec.name = pSphereItemRenamed | ||
| except: | ||
| print(sys.exc_info()[1]) |
There was a problem hiding this comment.
Not quite sure what this is testing in maya-usd. You are just testing USD primSpec renaming here, essentially, which should be tested in USD.
There was a problem hiding this comment.
@ppt-adsk I agree. this looks weird indeed. :)
ppt-adsk
approved these changes
Jul 7, 2020
ppt-adsk
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.