MAYA-105263 Improve draw performance for dense mesh #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The face vertex indices can jump drastically and cause cache hit rate to be low when drawing. Thus we need to sort the vertices so it can be more cache-friendly. After sorting, a remapping table is populated and used to prepare vertex buffers. This remapping table is updated only when topology is changed, so it won't happen often in common workflows. Previously we have had another remapping code path for vertex unsharing when there is any uniform or face-varying primvar. The commit will unify the two remapping processes with a single remapping table, making it easier to maintain.
williamkrick
suggested changes
Aug 17, 2020
williamkrick
approved these changes
Aug 17, 2020
williamkrick
approved these changes
Aug 17, 2020
|
testParentCmd failed but it is a known issue being fixed by @ppt-adsk . |
huidong-chen
added
the
ready-for-merge
kxl-adsk
approved these changes
Aug 19, 2020
kxl-adsk
deleted the
HdC-adsk/MAYA-105263/improve-dense-mesh-drawing-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The face vertex indices can jump drastically and cause cache hit rate
to be low when drawing. Thus we need to sort the vertices so it can be
more cache-friendly.
After sorting, a remapping table is populated and used to prepare vertex
buffers. This remapping table is updated only when topology is changed,
so it won't happen often in common workflows.
Previously we have had another remapping code path for vertex unsharing
when there is any uniform or face-varying primvar. The commit will unify
the two remapping processes with a single remapping table, making it
easier to maintain.